MSG/msg-desktop
1
0
Fork 1
Code Issues 2 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

ENH: Fixed sizing of the main window. #1

Open
eroesch wants to merge 8 commits from eroesch/msg-desktop:main into main
pull from: eroesch/msg-desktop:main
merge into: MSG:main
Conversation 5 Commits 8 Files changed 12 +224 -132
eroesch commented 2025-03-29 16:26:30 +00:00
First-time contributor
Copy link
No description provided.
eroesch added 1 commit 2025-03-29 16:26:30 +00:00
eroesch added 1 commit 2025-03-29 16:40:26 +00:00
eroesch added 1 commit 2025-03-31 10:47:51 +00:00
eroesch added 1 commit 2025-04-02 17:37:35 +00:00
cnelson commented 2025-04-03 00:55:15 +00:00
Owner
Copy link

So it seems there is an issue with the text box content. When running a long command like 'reinit' then the text box doesn't start following the output until after it has already extended a ways passed the box. If the output is canceled or finishes, then the auto scroll doesn't keep scrolling to the bottom. This causes future output to be obfuscated. I have included a video of what I am talking about

So it seems there is an issue with the text box content. When running a long command like 'reinit' then the text box doesn't start following the output until after it has already extended a ways passed the box. If the output is canceled or finishes, then the auto scroll doesn't keep scrolling to the bottom. This causes future output to be obfuscated. I have included a video of what I am talking about
Screen Recording 2025-04-02 at 6.52.15 PM.mov
4.5 MiB
eroesch commented 2025-04-03 08:14:42 +00:00
Author
First-time contributor
Copy link

Ah yes, I have noticed that. I'll have a look. I am not sure, but I don't think I changed anything functional in the scrollview, so this issue might also be in your original code?

Ah yes, I have noticed that. I'll have a look. I am not sure, but I don't think I changed anything functional in the scrollview, so this issue might also be in your original code?
eroesch added 1 commit 2025-04-04 10:28:14 +00:00
eroesch commented 2025-04-04 10:31:19 +00:00
Author
First-time contributor
Copy link

The issue was due to intrinsic limits to ScrollView, which doesn't behave when it is fed a lot of text and it also doesn't like the fast stream rate that we see in a log-like type of display. I have switched to using Text instead, which allows for manual scrolling.
It is not ideal, however, because it doesn't allow copy-paste, and scrolling while the stream receives data can be annoying.
But it works, and can easily handle several Reinit in a row. Let me know if that works for you.

The issue was due to intrinsic limits to ScrollView, which doesn't behave when it is fed a lot of text and it also doesn't like the fast stream rate that we see in a log-like type of display. I have switched to using Text instead, which allows for manual scrolling. It is not ideal, however, because it doesn't allow copy-paste, and scrolling while the stream receives data can be annoying. But it works, and can easily handle several Reinit in a row. Let me know if that works for you.
cnelson commented 2025-04-05 19:37:30 +00:00
Owner
Copy link

So I think this is pretty close. The main change I would request is that we make the background color for the text field to be a darker grey than the overall background color.

So I think this is pretty close. The main change I would request is that we make the background color for the text field to be a darker grey than the overall background color.
👍 1
eroesch added 1 commit 2025-04-05 21:02:27 +00:00
eroesch commented 2025-04-05 21:03:40 +00:00
Author
First-time contributor
Copy link

I have set it to black now. On my Mac, I have the automatic light/dark background depending on time of day, and it's 10pm here so I have not yet had time to see what it looks like on light background, but it should be fine ;)

I have set it to black now. On my Mac, I have the automatic light/dark background depending on time of day, and it's 10pm here so I have not yet had time to see what it looks like on light background, but it should be fine ;)
eroesch added 1 commit 2025-04-10 12:38:23 +00:00
eroesch added 1 commit 2025-04-16 16:00:26 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:eroesch-main
git checkout eroesch-main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff eroesch-main
git checkout eroesch-main
git rebase main
git checkout main
git merge --ff-only eroesch-main
git checkout eroesch-main
git rebase main
git checkout main
git merge --no-ff eroesch-main
git checkout main
git merge --squash eroesch-main
git checkout main
git merge --ff-only eroesch-main
git checkout main
git merge eroesch-main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: MSG/msg-desktop#1
No description provided.
Delete branch "eroesch/msg-desktop:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?